Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add hls-1.5.1 #11

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Add hls-1.5.1 #11

merged 2 commits into from
Dec 2, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Nov 29, 2021

@jneira jneira requested a review from hasufell November 29, 2021 21:07
@hasufell
Copy link
Member

hasufell commented Nov 29, 2021

The artifact for freebsd is missing as it failed in the linked pipeline

That needs to be built manually then

The artifacts from https://gitlab.haskell.org/haskell/haskell-language-server/-/pipelines/44521 should be copied in https://downloads.haskell.org/ghcup/unofficial-bindists/haskell-language-server/1.5.1/

Why? They can be uploaded on the HLS release page

@hasufell
Copy link
Member

The yaml is invalid, the tests are failing

@jneira
Copy link
Member Author

jneira commented Nov 29, 2021

Why? They can be uploaded on the HLS release page

right, do you think that should be way to do it hereinafter? Asking to start to think automating it in gitlab scripts

That needs to be built manually then

we could try to fix the build, at least to make it work for next releases, afaics it would need a ghcup fix:

curl --proto =https --tlsv1.2 -sSf https://get-ghcup.haskell.org
+ sh
Welcome to Haskell!
This script will download and install the following binaries:
  * ghcup - The Haskell toolchain installer
  * ghc   - The Glasgow Haskell Compiler
  * cabal - The Cabal build tool for managing Haskell software
  * stack - (optional) A cross-platform program for developing Haskell projects
  * hls   - (optional) A language server for developers to integrate with their editor/IDE
ghcup installs only into the following directory,
which can be removed anytime:
  /usr/home/vagrant/builds/0/haskell-haskell-language-server/FsB2Co4D/0/haskell/haskell-language-server/toolchain/.ghcup
13.0-RELEASE
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   146    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
"curl -Lf https://downloads.haskell.org/~ghcup/0.1.17.4/x86_64-portbld-freebsd13-ghcup-0.1.17.4" failed!

I see https://downloads.haskell.org/ghcup/0.1.17.4/x86_64-freebsd12-ghcup-0.1.17.4 but no freebsd13, the more recent version with freebsd13 support is https://downloads.haskell.org/ghcup/0.1.17.2/

could be included freebsd13 in 0.1.17.4?

otoh i dont have a freebsd at hand right now 😉

@hasufell
Copy link
Member

hasufell commented Nov 30, 2021

right, do you think that should be way to do it hereinafter? Asking to start to think automating it in gitlab scripts

did you upload them?

we could try to fix the build, at least to make it work for next releases, afaics it would need a ghcup fix:

FreeBSD 13 is irrelevant for now. We should build on 12.

@jneira
Copy link
Member Author

jneira commented Nov 30, 2021

right, do you think that should be way to do it hereinafter? Asking to start to think automating it in gitlab scripts

did you upload them?

will do

we could try to fix the build, at least to make it work for next releases, afaics it would need a ghcup fix:

FreeBSD 13 is irrelevant for now. We should build on 12.

I've seen your pr haskell/haskell-language-server#2420, thanks

@jneira
Copy link
Member Author

jneira commented Dec 1, 2021

will do

I am having problems wth my wifi connection and i was not able to download the artifacts from gitlab, the download stopped. 😞
To be sure the steps would be:

@hasufell
Copy link
Member

hasufell commented Dec 1, 2021

the binaries are here: https://gitlab.haskell.org/maerwald/haskell-language-server/-/pipelines/44701

Now they have to tar'ed up properly and uploaded to the hls release page. Then this PR needs to be fixed.

Copy link
Member

@hasufell hasufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are missing binaries as described above

@jneira
Copy link
Member Author

jneira commented Dec 2, 2021

sorry for the delay, a window update ruined my WiFi connection 2 days ago, it goes and comes but with weak signal, making impossible the download
I uninstalled it and it seems it has fixed the issue so will try asap

@jneira
Copy link
Member Author

jneira commented Dec 2, 2021

@hasufell i've uploaded the binaries and updated sha256sums, could you take a quick look to confirm everything is ok with them? thanks!
https://github.com/haskell/haskell-language-server/releases/tag/1.5.1

I've chosen freebsd12 for the release

@jneira jneira changed the title Add hls-1.5.1 (incomplete) Add hls-1.5.1 Dec 2, 2021
@hasufell hasufell merged commit 401b308 into haskell:master Dec 2, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants