-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add hls-1.5.1 #11
Add hls-1.5.1 #11
Conversation
jneira
commented
Nov 29, 2021
- The artifacts from https://gitlab.haskell.org/haskell/haskell-language-server/-/pipelines/44521 should be copied in https://downloads.haskell.org/ghcup/unofficial-bindists/haskell-language-server/1.5.1/
- is there someway to do it automatically?
- The artifact for freebsd is missing as itfailed in the linked pipeline
- It still needs sha256sum for those artifacts
That needs to be built manually then
Why? They can be uploaded on the HLS release page |
The yaml is invalid, the tests are failing |
right, do you think that should be way to do it hereinafter? Asking to start to think automating it in gitlab scripts
we could try to fix the build, at least to make it work for next releases, afaics it would need a ghcup fix:
I see https://downloads.haskell.org/ghcup/0.1.17.4/x86_64-freebsd12-ghcup-0.1.17.4 but no freebsd13, the more recent version with freebsd13 support is https://downloads.haskell.org/ghcup/0.1.17.2/ could be included freebsd13 in 0.1.17.4? otoh i dont have a freebsd at hand right now 😉 |
did you upload them?
FreeBSD 13 is irrelevant for now. We should build on 12. |
will do
I've seen your pr haskell/haskell-language-server#2420, thanks |
I am having problems wth my wifi connection and i was not able to download the artifacts from gitlab, the download stopped. 😞
|
the binaries are here: https://gitlab.haskell.org/maerwald/haskell-language-server/-/pipelines/44701 Now they have to tar'ed up properly and uploaded to the hls release page. Then this PR needs to be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are missing binaries as described above
sorry for the delay, a window update ruined my WiFi connection 2 days ago, it goes and comes but with weak signal, making impossible the download |
@hasufell i've uploaded the binaries and updated sha256sums, could you take a quick look to confirm everything is ok with them? thanks! I've chosen freebsd12 for the release |